Skip to content

Fix handler packages #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 8, 2019
Merged

Fix handler packages #298

merged 4 commits into from
Aug 8, 2019

Conversation

vishalbollu
Copy link
Contributor

Closes #

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested review from deliahu and 1vn August 8, 2019 16:18
1vn
1vn approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@1vn 1vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishalbollu vishalbollu merged commit 9b3be8b into master Aug 8, 2019
@vishalbollu vishalbollu deleted the fix-handler-packages branch August 8, 2019 16:53
deliahu pushed a commit that referenced this pull request Aug 8, 2019
@vishalbollu @deliahu
Fix handler packages (#298)
bb6d2bf 

(cherry picked from commit 9b3be8b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

+1 more reviewer

@1vn 1vn 1vn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishalbollu @deliahu @1vn